🦋 Changeset detected

Latest commit: 4e607b4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

I'm not too sure about this change. It's already a bit weird that we say 'the version should be deterministic' while defaulting to something that isn't deterministic; to double down on that with a test feels very much like 'do as I say, not as I do'.

Moreover, I'm not sure it's reliable. If I use Date.now() on my MacBook Pro from 2021 and load the config file twice, the timestamps are usually 2ms apart, sometimes 1ms. I bet if I was on a newer machine they would often be close enough for a false negative. Plus it's a shame to colour the function like that.

I think it might be worth us investing some time to think about what it would mean to have a deterministic version automatically. For example: I haven't thought this all the way through but could we generate the version dynamically by hashing the inputs to Vite? Maybe we need to account for externalised server-side dependencies, in which case perhaps we need to account for a lockfile/package.json in addition. Or maybe even if the code hasn't changed, we need to account for any data that changed in prerendered content, in which case perhaps we use a placeholder value at first, compute the version after prerendering, and then replace the placeholder in any outputs in which it appeared?

I'm not too sure about this change. It's already a bit weird that we say 'the version should be deterministic' while defaulting to something that isn't deterministic; to double down on that with a test feels very much like 'do as I say, not as I do'.

Moreover, I'm not sure it's reliable. If I use Date.now() on my MacBook Pro from 2021 and load the config file twice, the timestamps are usually 2ms apart, sometimes 1ms. I bet if I was on a newer machine they would often be close enough for a false negative. Plus it's a shame to colour the function like that.

I think it might be worth us investing some time to think about what it would mean to have a deterministic version automatically. For example: I haven't thought this all the way through but could we generate the version dynamically by hashing the inputs to Vite? Maybe we need to account for externalised server-side dependencies, in which case perhaps we need to account for a lockfile/package.json in addition. Or maybe even if the code hasn't changed, we need to account for any data that changed in prerendered content, in which case perhaps we use a placeholder value at first, compute the version after prerendering, and then replace the placeholder in any outputs in which it appeared?

Yeah, that's probably a better idea. I'll close this and create an issue for it so we can discuss more there.

issue here #14176